comaniac commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591159545 IMHO, since both @soiferj and @zhiics made great points from different perspective, I have another proposal. It's possible that @soiferj may encounter other issues while working on transformer models, so how about you try to fix them locally first like this PR (or an even better way is implementing all of them in a preprocessing pass/module), document down all the features you have implemented to support transformers and file an RFC. In that case, we all have a clear picture about what we need to have, and can focus on the implementation related discussion.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
