jmorrill commented on a change in pull request #4970: Added CopyFromBytes and
CopyToBytes convenience methods to NDArray. Fixed typos.
URL: https://github.com/apache/incubator-tvm/pull/4970#discussion_r385944181
##########
File path: include/tvm/runtime/ndarray.h
##########
@@ -306,6 +324,26 @@ inline void NDArray::CopyFrom(const NDArray& other) {
CopyFromTo(&(other.get_mutable()->dl_tensor), &(get_mutable()->dl_tensor));
}
+inline void NDArray::CopyFromBytes(const void* data, size_t nbytes) {
Review comment:
Ok, I have it calling the TVMArrayCopyFrom/ToBytes methods.
Are you saying to put the implementation into ndarray.cc ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
