masahi commented on issue #4964: [Torch] Add initial control flow support 
URL: https://github.com/apache/incubator-tvm/pull/4964#issuecomment-592938033
 
 
   @MarisaKirisame I have something relevant to share. I was told by one of the 
torchscript devs on their forum that he is working on a "functionalization" 
pass https://github.com/pytorch/pytorch/pull/33020, and that could help my use 
case. I'm not sure what exactly it does, but from looking at their code it 
seems it tries to find a "functional" subset of nodes, i.e. nodes with no 
impure operation, and extract it as a subgraph. I guess it helps applying some 
of their optimizations more aggressively.
   
   He also has others related PRs ongoing that aim at making the graph "more 
pure". One on removing inplace op 
https://github.com/pytorch/pytorch/pull/33186, another on removing list append 
https://github.com/pytorch/pytorch/pull/33199. I literally encountered these 
impure ops when I was trying to convert more realistic lstm models than the one 
I have in this PR, so these new feature in Torch could be useful to us later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to