anijain2305 commented on a change in pull request #5061: [Torch, QNN] Remove
FP32 piggy back and use QNN add/mul/concatenate
URL: https://github.com/apache/incubator-tvm/pull/5061#discussion_r392441508
##########
File path: python/tvm/relay/frontend/qnn_torch.py
##########
@@ -574,30 +577,69 @@ def _impl(inputs, _):
output_zero_point,
axis=-1,
out_dtype="uint8")
+
+ def _impl(inputs, _):
+ lhs = inputs[0]
+ rhs = inputs[1]
+ output_scale = _expr.const(inputs[2])
+ output_zero_point = _expr.const(inputs[3])
+ assert len(inputs) == 8, "Input quant params not found in op inputs"
+ # Manually added by add_input_quant_params_to_op_inputs above
+ input_scale_lhs = _expr.const(inputs[4])
+ input_zero_point_lhs = _expr.const(inputs[5])
+ input_scale_rhs = _expr.const(inputs[6])
+ input_zero_point_rhs = _expr.const(inputs[7])
+
+ if fp32_piggy_back:
+ logging.info("Piggy backing to FP32 op (PyTorch way)")
+ return torch_impl(lhs, rhs, input_scale_lhs, input_zero_point_lhs,
+ input_scale_rhs, input_zero_point_rhs,
+ output_scale, output_zero_point)
+
+ logging.info("Using QNN add/mul")
Review comment:
Remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
