tmoreau89 commented on a change in pull request #5124: [uTVM][Runtime]
Introduce Virtual Memory Allocator to CRT
URL: https://github.com/apache/incubator-tvm/pull/5124#discussion_r396671649
##########
File path: apps/bundle_deploy/Makefile
##########
@@ -37,6 +37,9 @@ demo: $(build_dir)/demo $(build_dir)/bundle.so
$(build_dir)/bundle_c.so $(build_
TVM_NUM_THREADS=1 $(build_dir)/demo $(build_dir)/bundle.so
$(build_dir)/cat.bin
TVM_NUM_THREADS=1 $(build_dir)/demo $(build_dir)/bundle_c.so
$(build_dir)/cat.bin
+test_crt: $(build_dir)/test $(build_dir)/test_bundle_c.so
$(build_dir)/test_data.bin $(build_dir)/test_output.bin
+ TVM_NUM_THREADS=1 $(build_dir)/test $(build_dir)/test_bundle_c.so
$(build_dir)/test_data.bin $(build_dir)/test_output.bin
$(build_dir)/test_graph.json $(build_dir)/test_params.bin
Review comment:
it would be nice to see some unit tests for the virtual memory allocator;
and add those to CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
