tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399422483
########## File path: src/node/structural_equal.cc ########## @@ -189,16 +201,19 @@ class RemapVarSEqualHandler : bool map_free_vars; /*! \brief Whether the children has been expanded via SEqualReduce */ bool children_expanded{false}; + /*! \brief whether the task is about graph equality(need remap). */ + bool graph_equal{false}; Task() = default; Task(ObjectRef lhs, ObjectRef rhs, bool map_free_vars) : lhs(lhs), rhs(rhs), map_free_vars(map_free_vars) {} }; - // list of pending tasks to be pushed to the stack. std::vector<Task> pending_tasks_; // Internal task stack to executed the task std::vector<Task> task_stack_; + // record current stack top Review comment: Given that this is private and won't generate docs, perhaps we can just go with this way ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services