csullivan commented on PR #15700: URL: https://github.com/apache/tvm/pull/15700#issuecomment-1712091276
@tqchen, is your primary feedback that you would prefer to see `rank/slice index` determined from the runtime (e.g. as you suggest R.disco.get_rank) as opposed to loading it from the serialized params file in order to keep the weight format simple? I want clarify your perspective, as we are hoping you are not making a stronger argument about the use of LiftTransformParams for build time parameter manipulation. I think @Lunderberg's comments are focused around concern that you are making this stronger argument. Because LiftTransformParams may lift symbolic variables, he is concerned that we would be throwing away information present at build time if we didn't have a way to serialize it. For `rank` we can agree this could be derived from the runtime. For other cases you are suggesting we can put this information into the embedded constant sections. Does this capture both your views correctly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
