LeshengJin commented on code in PR #15776:
URL: https://github.com/apache/tvm/pull/15776#discussion_r1330654090
##########
src/runtime/disco/ccl/utils.h:
##########
@@ -19,22 +19,21 @@
#ifndef TVM_RUNTIME_DISCO_NCCL_UTILS_H_
#define TVM_RUNTIME_DISCO_NCCL_UTILS_H_
-#include <nccl.h>
#include <tvm/runtime/data_type.h>
#include <tvm/runtime/disco/session.h>
#include "../utils.h"
namespace tvm {
namespace runtime {
-namespace nccl {
+namespace ccl {
-#define NCCL_CALL(cmd) \
- do { \
- ncclResult_t r = cmd; \
- if (r != ncclSuccess) { \
- LOG(FATAL) << "NCCLErrror: " << ncclGetErrorString(r); \
- } \
+#define NCCL_CALL(cmd) \
+ do { \
+ ncclResult_t r = cmd; \
+ if (r != ncclSuccess) { \
+ LOG(FATAL) << CCLString "Errror: " << ncclGetErrorString(r); \
+ } \
} while (0)
inline ncclDataType_t AsNCCLDataType(runtime::DataType dtype) {
Review Comment:
```suggestion
inline ncclDataType_t AsCCLDataType(runtime::DataType dtype) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
