Lunderberg commented on PR #15839: URL: https://github.com/apache/tvm/pull/15839#issuecomment-1740956980
> It doesn't assume that the user-provided parameters are identical across each call since kernels taking user-provided parameters (usually the first kernel) are not captured. Isn't that assumption present in `test_capture_fixed_inputs` at [this point](https://github.com/apache/tvm/blob/unity/tests/python/relax/test_transform_rewrite_cuda_graph.py#L620-L638), since the first provided parameters will be used for later calls? Though, perhaps we're using "user-provided" to mean two separate things. I was thinking of it as "the user of the relax function", but it could also mean "the user of the framework in which the relax function exists". The `params` input would be a "user-provided parameter" by the first definition, but not by the second definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
