Hzfengsy commented on code in PR #15919:
URL: https://github.com/apache/tvm/pull/15919#discussion_r1356599225
##########
python/tvm/relax/frontend/onnx/onnx_frontend.py:
##########
@@ -100,14 +100,17 @@ def get_constant(
return var
-def get_info(info_proto: onnx.onnx_ml_pb2.ValueInfoProto) -> Tuple[str, List,
str, List]:
+def get_info(info_proto: onnx.onnx_ml_pb2.ValueInfoProto, value_dict={}) ->
Tuple[str, List, str, List]:
Review Comment:
if `value_dict` is the output of the function, please move it to the return
values, instead of reference param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
