chunit-quic commented on PR #13728: URL: https://github.com/apache/tvm/pull/13728#issuecomment-1769831936
Hi @xiaolong18 Sorry for late reply. We finally can get back to here now. > the span should be filled quickly after it is parsed into relay ir. In this way, since the span has been filled, no consumer can rewrite this provider. is that right? Yes, that’s exactly how we handle this kind of problem. We will recommend fixing it this way. > the span should be filled quickly after it is parsed into relay ir. In this way, since the span has been filled, no consumer can rewrite this provider. is that right? Somehow it should be fine. Yet it might not be a good choice. Generally, using global variable is not desirable. Besides, the map cannot be declared in `_SpanFiller`, because lifecycle of `_SpanFiller` is within the scope of function `set_span`. That’s why we use the first solution to tackle this problem. Thanks, Joey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
