tqchen commented on PR #15916: URL: https://github.com/apache/tvm/pull/15916#issuecomment-1780084913
Thanks for the PR, I know this is indeed a generalization and there are some tradeoffs to be considered here. Specifically, we should consider the following alternative: - C0: We enforce `call_tir` to only take explicit Tuple and enforce in well-form check This indeed limit what we can do in terms of language, but would greatly simplify the logic that leverages CallTIR. And such simplicity helps us in a lot of cases since passes are simpler and more passes that depends on `call_tir` pattern matching would enjoy that simplicity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
