Lunderberg commented on PR #15916: URL: https://github.com/apache/tvm/pull/15916#issuecomment-1786122024
> Are we presently using inline tuples to simplify things significantly? I haven't found any locations that would require anything more than a binding lookup. Of the 19 instances of `Downcast<Tuple>` that I found using grep, none of them * 8 cases which are removed by this PR * 8 cases that use `Downcast<Tuple>` inside as part of an `IRModule` transform, and which could use the `UnwrapBindings` utility in this PR. * 2 cases that occur in VM codegen, to handle `"relax.call_builtin_with_ctx"`. * 1 case that occurs in a helper function, which is then used in `IRModule` transforms. The most complicated case involving `relax::Tuple` that I've found is in the dataflow pattern matching, but that already handles the unwrapping of tuple nodes [here](https://github.com/apache/tvm/blob/unity/src/relax/ir/dataflow_matcher.cc#L367) with the `TryGetVarOfVal` line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
