sergei-grechanik commented on a change in pull request #5171: [Arith] linear system and equation solver URL: https://github.com/apache/incubator-tvm/pull/5171#discussion_r403407406
########## File path: include/tvm/arith/linear_system.h ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/arith/linear_system.h + * \brief Linear system data structures and solvers + */ +#ifndef TVM_ARITH_LINEAR_SYSTEM_H_ +#define TVM_ARITH_LINEAR_SYSTEM_H_ + +#include <tvm/ir/expr.h> +#include <tvm/tir/expr.h> +#include <unordered_map> +#include <vector> + +namespace tvm { +namespace arith { + +using tir::Var; +using tir::VarNode; +using tir::IterVar; + +/*! + * \brief Represent a linear system including variables, their ranges and + * the linear relations between them (either equations or inequalities) Review comment: If variables are integer, I think it's still ok to call it IntegerSystem. But if we allow non-integer variables (I doubt it is a good idea), then I don't know, Set and System sound too unspecific, Constraints may be ok. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
