cbalint13 commented on code in PR #16425:
URL: https://github.com/apache/tvm/pull/16425#discussion_r1457320994
##########
src/target/llvm/llvm_instance.cc:
##########
@@ -845,10 +847,11 @@ const Array<String>
LLVMTargetInfo::GetAllLLVMCpuFeatures() const {
#else
MCInfo->getAllProcessorFeatures();
#endif
- Array<String> cpu_features;
+ // TVM doesn't have an FFI friendly Set, so use a Map instead for now
+ Map<String, String> cpu_features;
Review Comment:
This looks ugly in python backend, would be std::set better ?
See:
```
$ cat ./tvm-target.py
#!/usr/bin/python3
target = tvm.target.Target("llvm -mcpu=x86-64")
print( tvm.target.codegen.llvm_get_cpu_features(target) )
```
* BEFORE
```
$ ./tvm-target.py
["64bit", "64bit-mode", "cmov", "cx8", "fxsr", "idivq-to-divl",
"macrofusion",
"mmx", "nopl", "slow-3ops-lea", "slow-incdec", "sse", "sse2", "vzeroupper",
"x87"]
```
* AFTER
```
$ ./tvm-target.py
{"mmx": "", "cmov": "", "idivq-to-divl": "", "slow-incdec": "",
"macrofusion": "",
"fxsr": "", "slow-3ops-lea": "", "x87": "", "nopl": "", "sse2": "",
"vzeroupper": "",
"64bit": "", "sse": "", "cx8": "", "64bit-mode": ""}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
