Lunderberg commented on PR #16462: URL: https://github.com/apache/tvm/pull/16462#issuecomment-1910354803
> These PrimFuncs will not be dead code either, since they will actually be called in the final program. Hmm. My impression for the `funcs_to_keep` was that it forwarded all `PrimFunc`s that were called by the user-facing functions, and discarded all the rest. Any functions that were discarded could instead have been discarded by `DeadCodeElimination`. I'll test out the idea and make a separate PR if it works. For now, I think this PR is good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
