cbalint13 commented on code in PR #16484:
URL: https://github.com/apache/tvm/pull/16484#discussion_r1470902724
##########
tests/python/codegen/test_target_codegen_aarch64.py:
##########
@@ -476,5 +474,23 @@ def check_correct_assembly(type):
check_correct_assembly(type=dtype)
+@pytest.mark.skipif(
+ llvm_version_major() < 10, reason="Vscale is not supported in earlier
versions of LLVM"
Review Comment:
Just small nit,
In ```codegen_llvm.cc``` there is```#if TVM_LLVM_VERSION >= 110```, so it
would be ```major < 11``` instead of ```major < 10``` ?
I might be wrong, but being a test case only it is waivable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
