quic-sanirudh commented on PR #16557: URL: https://github.com/apache/tvm/pull/16557#issuecomment-1946342128
> sorry for getting into this late. I see we introduced some metadata by having a map from pointer to metadata, @quic-sanirudh , an alternative would be to introduce a HexagonBuffer object that contains the meta data like OpenCL https://github.com/apache/tvm/blob/main/src/runtime/opencl/opencl_common.h#L382 Thanks for the review @tqchen. I guess you're referring to the pointer table we allocate to store 2D tensors. What we want is to allocate 2D physical tensors where the first dimension is just a list of pointers to blocks of data. This is planned so that we can take full advantage of the very little VTCM memory we have in hexagon. I'll take a look at the OpenCL code mentioned here and see if I can refactor my patch based on the ideas there, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
