Lunderberg commented on code in PR #16569:
URL: https://github.com/apache/tvm/pull/16569#discussion_r1506395444
##########
tests/python/tir-transform/test_tir_transform_lower_cross_thread_reduction.py:
##########
@@ -116,7 +116,8 @@ def no_normal_reduction(a: T.handle, b: T.handle) -> None:
B[vi] = B[vi] + A[vi, vk]
-@T.prim_func
Review Comment:
In the `T.evaluate(T.tvm_thread_allreduce(...))` call, `k` should be
replaced with `vk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
