Lunderberg commented on code in PR #16660:
URL: https://github.com/apache/tvm/pull/16660#discussion_r1507746125
##########
tests/python/tir-schedule/test_tir_schedule_cache_read_write.py:
##########
@@ -1379,6 +1379,54 @@ def
test_cache_read_fail_invalid_storage_scope(use_block_name):
sch.cache_read(block_b, 0, "test_scope")
+def test_cache_read_allocate_const():
+ @T.prim_func
+ def before(A: T.Buffer((8), "float32"), C: T.Buffer((8), "float32")):
+ B = T.allocate_const([0.0, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7],
"float32", [8])
+ B_buf = T.decl_buffer((8), dtype="float32", data=B)
+ for i in T.serial(128):
+ with T.block("C"):
+ vi = T.axis.remap("S", [i])
+ T.reads(A[vi], B_buf[vi])
Review Comment:
Nitpick: The `T.reads` and `T.writes` annotations can be inferred in
TVMScript parsing. Unless the test case is specifically checking the values in
these annotations, readability of the test case can be improved by removing
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
