Lunderberg commented on PR #16679: URL: https://github.com/apache/tvm/pull/16679#issuecomment-1985866404
> Thanks for your suggestion! Yes without this PR, but add preconfition x>0 both TestCases in Min and Max are passed. BTW, could please give me one more hint on how to add `T.Assert(m > 0, "Some error message here")` automatically to all the function in an IRModule if there are symbolic shapes ? Hmm, that's the tricky part. This assertion is specific to your use case, but isn't true in general. For symbolic shapes in both TIR and Relax, it is legal for the axis to have an extent of zero. How are you currently generating the PrimFunc from your script? > BTW, should i close this PR or should i keep the added testcase by adding precondition `x>0` `TestCase(tvm.te.min(0, fld(x + 3, 4) * 4 - 1), 0, x > 0)` and cancel the change in rewrite_simplify ? I think it's okay to close this PR, as that functionality should be covered by the test cases for `FloorDiv` simplification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
