alexbooth commented on issue #5261: [RELAY][BYOC] Add support for composite 
functions in BYOC
URL: https://github.com/apache/incubator-tvm/pull/5261#issuecomment-610509436
 
 
   Partitioning looks good for me with a simple pattern, conv2d_bias_relu. I'm 
seeing the check fail in IsOp for composite functions however. Maybe for 
another PR.
   
   ```c++
     bool IsOp(const CallNode* call, const std::string& op_name) const {
       const auto* op_node = call->op.as<OpNode>();
       CHECK(op_node) << "Expects a single op.";
       Op op = GetRef<Op>(op_node);
       return op == Op::Get(op_name);
     }
   ```
   
https://github.com/mbaret/tvm/blob/a197bca20a8effc48d06388190aa1b5f3b525ef6/src/relay/backend/contrib/codegen_c/codegen_c.h#L191-L205
   
   ```TVMError: Check failed: op_node: Expects a single op.```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to