zhiics commented on a change in pull request #5251: [RUNTIME] Auto conversion
from str to runtime::String in PackedFUnc
URL: https://github.com/apache/incubator-tvm/pull/5251#discussion_r405092183
##########
File path: include/tvm/runtime/packed_func.h
##########
@@ -554,6 +512,10 @@ class TVMArgValue : public TVMPODValue_ {
return std::string(value_.v_str);
}
}
+ operator tvm::runtime::String() const {
+ // directly use the std::string constructor for now.
+ return tvm::runtime::String(operator std::string());
Review comment:
so let's just `return AsObjectRef<tvm::runtime::String>()` for now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
