slyubomirsky commented on code in PR #16543:
URL: https://github.com/apache/tvm/pull/16543#discussion_r1538390306
##########
src/tir/transforms/arg_binder.cc:
##########
@@ -186,18 +191,8 @@ void ArgBinder::BindDLTensor(const Buffer& buffer, const
PrimExpr& device_type,
if (!(buffer->dtype == DataType::Int(1) || buffer->dtype == DataType::Int(4)
||
buffer->dtype == DataType::UInt(4))) {
auto type_msg = tvm::tir::StringImm(type_err_msg.str());
- asserts_.emplace_back(AssertStmt(a_ndim == v_ndim, msg, nop));
Review Comment:
Was this just a duplicate?
##########
rust/tvm-graph-rt/tests/test_tvm_basic/build.rs:
##########
@@ -48,10 +48,6 @@ fn main() -> Result<()> {
obj_file.exists(),
"Could not build tvm lib: {}",
String::from_utf8(output.stderr)?
- .trim()
- .split("\n")
- .last()
- .unwrap_or("")
Review Comment:
Wonder how this came up. Just for readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
