ekalda commented on code in PR #16782:
URL: https://github.com/apache/tvm/pull/16782#discussion_r1551562114
##########
src/tir/transforms/vectorize_loop.cc:
##########
@@ -182,21 +199,29 @@ class Vectorizer : public StmtMutator, public
ExprFunctor<PrimExpr(const PrimExp
if (a.same_as(op->a) && b.same_as(op->b)) {
return GetRef<PrimExpr>(op);
} else {
- // TODO(ekalda): P5 in https://github.com/apache/tvm/issues/16455
- int lanes = std::max(a.dtype().lanes(), b.dtype().lanes());
- if (lanes != 1) {
+ bool is_vec_a = a.dtype().is_scalable_or_fixed_length_vector();
+ bool is_vec_b = b.dtype().is_scalable_or_fixed_length_vector();
+ if (is_vec_a && is_vec_b) {
+ // Let's not multiply scalable and fixed length vectors
+ ICHECK(a.dtype().is_scalable_vector() ==
b.dtype().is_scalable_vector());
+ }
+ if (is_vec_a || is_vec_b) {
const RampNode* b_ramp = b.as<RampNode>();
const RampNode* a_ramp = a.as<RampNode>();
- if (a_ramp && b.dtype().lanes() == 1 && analyzer_.CanProve(b > 0)) {
- int lanes = static_cast<int>(Downcast<IntImm>(a_ramp->lanes)->value);
+ if (a_ramp && !b_ramp && analyzer_.CanProve(b > 0)) {
Review Comment:
Yes let's keep it as close as the original behaviour as possible :)
##########
src/tir/transforms/vectorize_loop.cc:
##########
@@ -182,21 +199,29 @@ class Vectorizer : public StmtMutator, public
ExprFunctor<PrimExpr(const PrimExp
if (a.same_as(op->a) && b.same_as(op->b)) {
return GetRef<PrimExpr>(op);
} else {
- // TODO(ekalda): P5 in https://github.com/apache/tvm/issues/16455
- int lanes = std::max(a.dtype().lanes(), b.dtype().lanes());
- if (lanes != 1) {
+ bool is_vec_a = a.dtype().is_scalable_or_fixed_length_vector();
+ bool is_vec_b = b.dtype().is_scalable_or_fixed_length_vector();
+ if (is_vec_a && is_vec_b) {
+ // Let's not multiply scalable and fixed length vectors
+ ICHECK(a.dtype().is_scalable_vector() ==
b.dtype().is_scalable_vector());
+ }
+ if (is_vec_a || is_vec_b) {
const RampNode* b_ramp = b.as<RampNode>();
const RampNode* a_ramp = a.as<RampNode>();
- if (a_ramp && b.dtype().lanes() == 1 && analyzer_.CanProve(b > 0)) {
- int lanes = static_cast<int>(Downcast<IntImm>(a_ramp->lanes)->value);
+ if (a_ramp && !b_ramp && analyzer_.CanProve(b > 0)) {
+ PrimExpr lanes = a_ramp->lanes;
return Ramp(a_ramp->base * b, a_ramp->stride * b, lanes);
}
- if (b_ramp && a.dtype().lanes() == 1 && analyzer_.CanProve(a > 0)) {
- int lanes = static_cast<int>(Downcast<IntImm>(b_ramp->lanes)->value);
+ if (b_ramp && !a_ramp && analyzer_.CanProve(a > 0)) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
