Lunderberg commented on PR #16833: URL: https://github.com/apache/tvm/pull/16833#issuecomment-2039844557
Well, a check that finds a large number of errors is a good check to have, and a good source of cleanup. Unfortunately, I think it means that this PR will need to sit until I have time to clean them up. The current CI failures are due to transforms that update a function's signature, but do not propagate that change to the `GlobalVar`. There's enough failures that it should have a common utility to resolve the mismatch, updating the `GlobalVar` of the function, and replacing it at all call sites. Resolving this cannot be done as part of the block builder's normalizer, because it would depend on the order in which the caller/callee are visited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
