comaniac opened a new pull request #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes URL: https://github.com/apache/incubator-tvm/pull/5277 Since we are working on TRT support with BYOC infra, we added some features and fixed some bugs in AnnotateTarget and MergeCompilerRegion passes. Here are the change logs: **Bug Fix** - Fixed type propagation and tuple bug in AnnotateTarget pass (@trevor-m ). - Corrected the namespace of MergeCompilerRegion. **Support Multiple Targets** - Add multiple target support to AnnotateTarget. Now it takes either a target string or a list of targets. AnnotateTarget will invoke target specific op-based rule functions in order. - Accordingly, now regions in AnnotateRegionSet also have target attribute. **Unified Pass Input/Output** - Previously the output graph of AnnotateTarget annotates the ops for external target, but the input graph of AnnotateRegionSet requires every op to be annotated. Now both AnnotateTarget and MergeCompilerRegion passes output a graph with all ops annotated. Ops that will be handeled by TVM will also be annotated with target "default". - Accordingly, we don't need AnnotateRestDefault anymore. - Although ideally PartitionGraph should handle default annotations, we currently do not have this process yet. This PR makes a workaround by adding a temporary pass that removes all default annotations. A TODO was added as a reminder. **Example Codegen (DNNL) Improvements** - Support multiple outputs in DNNL codegen. - Temporary turn off mobilnet unit tests due to constant node issue. cc @zhiics, @trevor-m, @mbaret, @manupa-arm
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
