Anndrey24 commented on code in PR #16899: URL: https://github.com/apache/tvm/pull/16899#discussion_r1574925382
########## python/tvm/topi/arm_cpu/conv2d_gemm.py: ########## @@ -164,6 +159,7 @@ def compute_conv2d_gemm_without_weight_transform( tile_K_A = 4 Review Comment: I refactored out this logic block into a separate function which is now also used in the schedule to ensure that tiling is consistent between compute definition and its associated schedule, without needing to change the values in two separate places like before. I think the compute definition also looks cleaner as a result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org