lhutton1 commented on code in PR #16962: URL: https://github.com/apache/tvm/pull/16962#discussion_r1592013962
########## src/target/llvm/codegen_llvm.cc: ########## @@ -1127,6 +1128,13 @@ void CodeGenLLVM::SetTargetAttributes(llvm::Function* func) { if (!features.empty()) { func->addFnAttr("target-features", features); } +#if TVM_LLVM_VERSION >= 130 + // Add vscale_range() function attribute when appropriate. + if (llvm_target_->TargetHasCPUFeature("sve") || llvm_target_->TargetHasCPUFeature("sme")) { Review Comment: Apologies, I had another thought about this. Since it's AArch64 specific, perhaps we should move it to `codegen_aarch64.cc`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org