Lunderberg commented on code in PR #17033:
URL: https://github.com/apache/tvm/pull/17033#discussion_r1617278146
##########
src/relax/transform/fuse_ops.cc:
##########
@@ -262,16 +262,11 @@ class GraphCreator : public ExprVisitor {
IndexedForwardGraph::Node* leaf_node = nullptr;
if (it != graph_.node_map.end()) {
leaf_node = it->second;
- } else if (leaf_expr->IsInstance<ConstantNode>() ||
leaf_expr->IsInstance<ShapeExprNode>() ||
- leaf_expr->IsInstance<PrimValueNode>() ||
leaf_expr->IsInstance<StringImmNode>() ||
- leaf_expr->IsInstance<DataTypeImmNode>()) {
+ } else {
Review Comment:
@tqchen Responding to the comment
[here](https://github.com/apache/tvm/pull/17022#discussion_r1613292617), with
conversation migrated to the new PR.
> Is this intended change? Seems that we should consider sass where constant
value(and there may not be a binding pt)
This change is intentional, and maintains the same behavior for constants as
before. Prior to this change, the `else if` condition was entered for five of
the six child classes of `relax::LeafExprNode`, and the `else` branch with the
`LOG(FATAL)` was only entered for a `relax::Var`.
With this change, the behavior of all LeafExpr subclasses is the same: If
encoutered without being previously assigned to a group, they are treated as a
group of size one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
