Lunderberg opened a new pull request, #17135: URL: https://github.com/apache/tvm/pull/17135
Prior to this commit, a `tvm::NameSupply` needed to be constructed with an explicit `const String& prefix` argument. Omitting this argument would fall back to the default constructor provided by the `TVM_DEFINE_MUTABLE_OBJECT_REF_METHODS` macro, producing a `NameSupply` holding a nullptr. This then leads to a segfault when the null `NameSupply` is used. The vast majority of usages of `NameSupply::NameSupply` (29 out of 31) initialize it with an empty `prefix` string. The remaining two use cases initialize it with a non-empty `prefix` string. There are no cases in which a null `NameSupply` is initialized. This commit updates `NameSupply` to use the `TVM_DEFINE_MUTABLE_NOTNULLABLE_OBJECT_REF_METHODS` macro instead of `TVM_DEFINE_MUTABLE_OBJECT_REF_METHODS`. This allows the default constructor to provide the common usage of a `NameSupply` with an empty prefix, rather than the error-prone usage of a null `NameSupply` A similar change is also made for `GlobalVarSupply`, as the majority of its uses also default to an empty prefix (11 out of 13). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
