tqchen commented on PR #17216:
URL: https://github.com/apache/tvm/pull/17216#issuecomment-2261226877
Thanks for pointing out the frontend case, I still think being explicit is
helpful and aims for a consistency check with good error messages. Having such
explicit argument makes the "intent" clear. Say directly transpiles the code to
python, with the explicit sinfo, we can write down the semantics explicitly
```python
def call_tir(func, args, out_sinfo):
out = alloc_outputs(out_sinfo)
func(*args, unpack_outputs(out))
return out
```
omitting the out_sinfo, while indeed ok in some cases, was not always
derivable, and the intent was less clear. I know the arguments can go another
way to reduce the amount users type. In this particular case, having good well
form check about consistency would help a lot toward that direction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
