FrozenGene commented on issue #4857: Windows Support for cpp_rpc URL: https://github.com/apache/incubator-tvm/pull/4857#issuecomment-612733079 > Ok @FrozenGene I have made some changes to the CMakeLists.txt > > Should I place "`tvm_option(USE_CPP_RPC "Build CPP RPC" OFF)`" with an "`if(WIN32)`" around it? It will compile for linux, just it won't have the android options available in your Makefile. > > Also I have: > > ``` > if(WIN32) > cmake_minimum_required(VERSION 3.9) > else() > cmake_minimum_required(VERSION 3.2) > endif() > ``` > > This gives a min cmake version of 3.9 on Windows. It is not needed for this, but was hoping to sneak in interprocedural optimizations in Windows builds for extra perf. (ex `set_property(TARGET tvm PROPERTY INTERPROCEDURAL_OPTIMIZATION TRUE)` ) . > > I can remove that if its a problem and find a way to do it via compiler switches in a later PR. I suggest when we build CPP_RPC on non-Windows platforms, we will raise one `fatal` and prompt users to use `app/Makefile` to build CPP RPC. For CMake version, It is better to use the same version on Linux / Windows. We cold add it in compiler options in later pr.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
