trevor-m commented on a change in pull request #5320: [BYOC] Prevent duplicate
outputs in subgraph Tuple
URL: https://github.com/apache/incubator-tvm/pull/5320#discussion_r407711418
##########
File path: tests/python/relay/test_annotated_regions.py
##########
@@ -56,7 +56,7 @@ def test_region_set_creator_diamond():
'test_target',
[cb_1],
[cb_1, O_1, ce_1, ce_2],
- [ce_1, ce_2],
Review comment:
Thanks @comaniac for the review and comments! I like your proposed solutions
B and C. B seems to be the cleanest to implement while C helps keep the passes
not codependent on each other as much. I would be happy to implement any of
those, what do others think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
