mshr-h commented on code in PR #17863:
URL: https://github.com/apache/tvm/pull/17863#discussion_r2052221500
##########
tests/python/relax/test_from_exported_to_cuda.py:
##########
@@ -588,5 +584,332 @@ def forward(self, x):
assert_torch_output_vs_tvm_from_exported_to_cuda(raw_data, torch_module,
target, dev)
+@tvm.testing.parametrize_targets("cuda")
Review Comment:
I'm not confident whether we need e2e tests for every ops.
The upside is we may not have to care about pytorch incompatible API update
such as #17680 we hit recently.
The downside is that they increase the CI pressure, which results in a slow
development speed.
Maybe nightly is a good place for e2e tests?
cc @Hzfengsy @tqchen @yongwww
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
