ConvolutedDog commented on code in PR #17902:
URL: https://github.com/apache/tvm/pull/17902#discussion_r2066116925
##########
include/tvm/runtime/object.h:
##########
@@ -890,7 +890,7 @@ inline bool Object::IsInstance() const {
// The condition will be optimized by constant-folding.
if (TargetType::_type_child_slots != 0) {
uint32_t end = begin + TargetType::_type_child_slots;
- if (self->type_index_ >= begin && self->type_index_ < end) return true;
+ if (self->type_index_ >= begin && self->type_index_ <= end) return
true;
Review Comment:
Fixed in commit
https://github.com/apache/tvm/pull/17902/commits/a8cebe948d351539fb935da3c38c8fe963f4ddcf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
