Ghosts381937 commented on PR #17765: URL: https://github.com/apache/tvm/pull/17765#issuecomment-2933426323
Thank you for help me fix the issue! > Thanks @Ghosts381937 . A few things to note, we indeed should simplify to make mul coefficient in rhs by default which is a convention in the code base. You made a right observation about the rule `TVM_TRY_REWRITE(matches_one_of(x * y + x, y * x + x, x + y * x, x + x * y), x * (y + 1));` violating this principle. > > Based on your observation, #18031 should fix the issue as well as the testcase you raised. Thank you for being careful and digging into the issue, arith module is something that we need to carefully maintain so this really helps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
