cbalint13 commented on PR #18246: URL: https://github.com/apache/tvm/pull/18246#issuecomment-3234823791
> actually we may not need this as long as the bakctrace is intialize by git submodule update --init It looked (and still looks) gone for me, like this: ``` $ git clone --depth 1 https://github.com/apache/tvm tvm.test {...} Receiving objects: 100% (4029/4029), 7.46 MiB | 12.91 MiB/s, done. Resolving deltas: 100% (1008/1008), done. $ cd tvm.test $ git submodule update --init --depth 1 3rdparty/libbacktrace error: pathspec '3rdparty/libbacktrace' did not match any file(s) known to git ``` Ahh, it changed home (i did not noticed this) ... ``` git submodule update --init | grep libbacktrace Cloning into '/home/cbalint/work/GITHUB/tvm.test/ffi/3rdparty/libbacktrace'... ``` I am sorry then, you are right ! I maintain since 4-5 years aautomated rpm packagebuild that use that path desribed earlier (with explicit path): https://download.copr.fedorainfracloud.org/results/rezso/ML/fedora-rawhide-x86_64/09460091-tvm/tvm.spec ---- But beside that, if we now reached here accidentally (and fixed MacOS build) IMHO it is easier and cleaner to maintain from cmake "way" than from "git submodule" way. The advantage with cmake is that it can download source conditionally on the case it cannot be found locally (precompiled). This can be reverted then if you decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
