gemini-code-assist[bot] commented on PR #18347: URL: https://github.com/apache/tvm/pull/18347#issuecomment-3341215296
## Summary of Changes Hello @Aminsed, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust, deterministic CUDA test to validate the `tir.analysis.verify_gpu_code` utility's ability to detect shared memory overflows. By creating a direct TIR kernel that attempts to allocate 64KB of shared memory and asserting its failure against a 48KB limit, the PR ensures the verification mechanism functions as expected. Additionally, it integrates an opt-in pipeline toggle and documentation for configuring per-device shared memory caps, enhancing the flexibility and diagnostic capabilities for GPU code without altering any default system behaviors. ### Highlights * **New Deterministic CUDA Test**: A new, deterministic CUDA test has been added to validate shared memory limits using `tir.analysis.verify_gpu_code`. * **Shared Memory Overflow Verification**: The test specifically verifies that a 64KB shared buffer allocation fails verification when the maximum allowed shared memory per block is set to 48KB. * **Opt-in GPU Code Verification**: An optional, opt-in GPU code verification step has been integrated into the TIR pipeline, allowing users to enable shared memory limit checks via `PassContext` configuration. * **Configurable Shared Memory Cap**: The `tir.cuda.max_shared_memory_per_block` configuration option allows overriding the per-device shared memory cap for verification, with a default conservative limit of 48KB. * **No Default Behavior Altered**: All changes are confined to testing and optional configurations, ensuring no existing default behaviors are modified. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
