gemini-code-assist[bot] commented on code in PR #18348:
URL: https://github.com/apache/tvm/pull/18348#discussion_r2384268466
##########
python/tvm/libinfo.py:
##########
@@ -66,6 +66,7 @@ def get_dll_directories():
# Pip lib directory
dll_path.append(ffi_dir)
+ dll_path.append(os.path.join(ffi_dir, "lib"))
Review Comment:
This change effectively resolves the library loading issue. However, it
appears to be a workaround for an underlying inconsistency in the installation
process. It seems `CMakeLists.txt` has duplicate `install` directives for the
`tvm` and `tvm_runtime` libraries, which can lead to them being placed in
different directories based on the build context (e.g., `pip install` vs. a
manual `make install`).
For better long-term maintainability, we should consider addressing the root
cause in the CMake setup to ensure libraries are always installed to a single,
predictable location. This would simplify the library discovery logic and make
the packaging more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
