gemini-code-assist[bot] commented on code in PR #18402:
URL: https://github.com/apache/tvm/pull/18402#discussion_r2471118985
##########
tests/python/relax/test_frontend_from_exported_program.py:
##########
@@ -923,21 +970,40 @@ def forward(self, input1, input2):
class expected:
@R.function
def main(
- input_1: R.Tensor((1, 3, 10, 10), dtype="float32"),
- input_2: R.Tensor((1, 3, 10, 10), dtype="float32"),
+ input1: R.Tensor((1, 3, 10, 10), dtype="float32"),
+ input2: R.Tensor((1, 3, 10, 10), dtype="float32"),
) -> R.Tuple(R.Tensor((1, 3, 10, 10), dtype="float32")):
# block 0
with R.dataflow():
- lv: R.Tensor((1, 3, 10, 10), dtype="float32") =
R.log_add_exp(input_1, input_2)
- gv: R.Tuple(R.Tensor((1, 3, 10, 10), dtype="float32")) = (lv,)
+ lv: R.Tensor((1, 3, 10, 10), dtype="bool") =
R.greater_equal(input1, input2)
+ lv1: R.Tensor((1, 3, 10, 10), dtype="float32") = R.where(lv,
input1, input2)
+ lv2: R.Tensor((1, 3, 10, 10), dtype="float32") = R.where(lv,
input2, input1)
+ lv3: R.Tensor((1, 3, 10, 10), dtype="float32") = R.abs(input1)
+ lv4: R.Tensor((1, 3, 10, 10), dtype="bool") = R.not_equal(
+ lv3, R.const(float("inf"), "float32")
+ )
+ lv5: R.Tensor((1, 3, 10, 10), dtype="bool") = R.equal(input1,
input1)
+ lv6: R.Tensor((1, 3, 10, 10), dtype="bool") = R.multiply(lv5,
lv4)
Review Comment:
For better readability and to be more idiomatic, consider using
`R.logical_and` instead of `R.multiply` when performing a logical AND operation
on boolean tensors. While `R.multiply` works correctly for booleans in TVM,
`R.logical_and` more clearly expresses the intent.
```suggestion
lv6: R.Tensor((1, 3, 10, 10), dtype="bool") =
R.logical_and(lv5, lv4)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
