tqchen commented on code in PR #18415:
URL: https://github.com/apache/tvm/pull/18415#discussion_r2484815286
##########
web/src/runtime.ts:
##########
@@ -1396,7 +1396,18 @@ export class Instance implements Disposable {
});
const recSource = buffer.slice(rec.byteOffset, rec.byteOffset +
rec.nbytes);
// first sync copy to cpu.
- this.ctx.arrayDecodeStorage(cpu_arr, new Uint8Array(recSource),
rec.format, rec.dtype);
+ this.withNewScope(() => {
+ const retValue = this.ctx.arrayDecodeStorage(
Review Comment:
would be good to document the rationale here, any better ways than try catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
