gemini-code-assist[bot] commented on PR #18420: URL: https://github.com/apache/tvm/pull/18420#issuecomment-3489198078
## Summary of Changes Hello @tlopex, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for decomposed operators within the PyTorch frontend for TVM Relax, specifically addressing and correcting the Intermediate Representation (IR) generated for several key operations. The changes ensure that `roll`, `select_slice`, and `squeeze` operators are accurately translated when PyTorch's decomposition mechanism is active, leading to more precise and robust model compilation. ### Highlights * **Squeeze Operator Fix**: Improved the `_squeeze` operator's handling of `dims` in the PyTorch frontend to correctly filter axes with dimension 1, aligning with PyTorch's decomposition behavior. * **Slice Operator Robustness**: Enhanced the `_slice` operator to correctly parse and apply `dim`, `start`, `end`, and `step` arguments, ensuring accurate translation of PyTorch's `select_slice` operations into `relax.op.strided_slice`. * **Decomposed Roll IR**: Updated the expected Intermediate Representation (IR) for `roll` operations in tests to reflect a more decomposed form, utilizing `arange`, `add`, `mod`, and `take` primitives instead of `strided_slice` and `concat`. * **Decomposed Split/Unbind IR**: Modified the expected IR for `split` and `unbind` operations in tests to use more granular `strided_slice` and `squeeze` operations, or explicit index lists for `split`, aligning with decomposed operator patterns. * **Test Suite Enhancement**: Enabled PyTorch operator decomposition (`run_ep_decomposition=True`) across various frontend tests, including `reshape`, `roll`, `slice`, `slice_scatter`, `chunk`, `unbind`, and `squeeze`, to validate the new decomposed operator support. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
