(tvm) branch main updated: [Relax] Remove obsolete TODO comments (#18649)

[tlopex]

This is an automated email from the ASF dual-hosted git repository.

tlopex pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git


The following commit(s) were added to refs/heads/main by this push:
     new 99c1d9245f [Relax] Remove obsolete TODO comments (#18649)
99c1d9245f is described below

commit 99c1d9245f1a54890da526f32f7e1f763173163d
Author: Guan-Ming (Wesley) Chiu <105915352+guan404m...@users.noreply.github.com>
AuthorDate: Sun Jan 11 21:45:07 2026 +0800

    [Relax] Remove obsolete TODO comments (#18649)
    
    - Remove TODO about `ctx->ReportWarning()` since LOG(WARNING) is the
    standard pattern
    - Remove TODO about skipping type params/constraints since the current
    FuncType implementation only contains arg_types and ret_type fields.
    `type_params` and `type_constraints` don't exist in the codebase.
    - Fixed typo in warning message
---
 python/tvm/relax/testing/ast_printer.py | 1 -
 src/relax/op/tensor/index.cc            | 3 +--
 src/relax/op/tensor/manipulate.cc       | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/python/tvm/relax/testing/ast_printer.py 
b/python/tvm/relax/testing/ast_printer.py
index ca50d39f7b..dd17b2060b 100644
--- a/python/tvm/relax/testing/ast_printer.py
+++ b/python/tvm/relax/testing/ast_printer.py
@@ -260,7 +260,6 @@ class ASTPrinter(ExprFunctor):
                 "FuncType",
                 arg_types=self.build_list(map(self.visit_type_, 
type_node.arg_types)),
                 ret_type=self.visit_type_(type_node.ret_type),
-                # TODO: skipping type params and type constraints
             )
         raise ValueError(f"Invalid Relax Type {type_node} ({type(type_node)})")
 
diff --git a/src/relax/op/tensor/index.cc b/src/relax/op/tensor/index.cc
index b346b6681b..a5b6225ec4 100644
--- a/src/relax/op/tensor/index.cc
+++ b/src/relax/op/tensor/index.cc
@@ -84,8 +84,7 @@ StructInfo InferStructInfoTake(const Call& call, const 
BlockBuilder& ctx) {
   }();
 
   if (indices_sinfo->IsUnknownDtype()) {
-    // TODO(tvm-team): Do we have an equivalent of `ctx->ReportFatal` for 
warning?
-    LOG(WARNING) << "Data type of indice has not been specified. Assume it has 
an integer type.";
+    LOG(WARNING) << "Data type of indices has not been specified. Assume it 
has an integer type.";
   } else if (!(indices_sinfo->dtype.is_int() || 
indices_sinfo->dtype.is_uint())) {
     ctx->ReportFatal(Diagnostic::Error(call)
                      << "Take op requires the input indices to have integer 
dtype. However, the "
diff --git a/src/relax/op/tensor/manipulate.cc 
b/src/relax/op/tensor/manipulate.cc
index afb749a297..d4bbbd208b 100644
--- a/src/relax/op/tensor/manipulate.cc
+++ b/src/relax/op/tensor/manipulate.cc
@@ -2617,7 +2617,7 @@ StructInfo InferStructInfoScatterElements(const Call& 
call, const BlockBuilder&
   }
 
   if (indices_sinfo->IsUnknownDtype()) {
-    LOG(WARNING) << "Data type of indice has not been specified. Assume it has 
an integer type.";
+    LOG(WARNING) << "Data type of indices has not been specified. Assume it 
has an integer type.";
   } else if (!(indices_sinfo->dtype.is_int() || 
indices_sinfo->dtype.is_uint())) {
     ctx->ReportFatal(
         Diagnostic::Error(call)