This is an automated email from the ASF dual-hosted git repository.
spectrometerHBH pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new bac59afa0d [TIRx] Improve BufferStore cast warning context (#20038)
bac59afa0d is described below
commit bac59afa0d646be7dd9ff938dd7a371b8fa9bfd1
Author: Shushi Hong <[email protected]>
AuthorDate: Wed Jul 22 15:57:35 2026 -0400
[TIRx] Improve BufferStore cast warning context (#20038)
This PR improves the precision-loss warning emitted while building a
`BufferStore`.
Before this change, the warning only displayed the LHS and RHS dtypes,
making it difficult to identify the failing kernel when many kernels
were built together:
```text
Warning: Casting in BufferStore may lose precision:
LHS is `T.int32`, RHS is `T.float32`, indexing lanes: 1
```
After this change, the warning also displays the current kernel name and
the complete `BufferStore` node:
```text
Warning: Casting in BufferStore may lose precision:
LHS is `T.int32`, RHS is `T.float32`, indexing lanes: 1,
kernel: `warning_kernel`
BufferStore:
A = T.Buffer((4,), "int32")
B = T.Buffer((4,))
i = T.int32()
A[i] = T.Cast("int32", B[i] + T.float32(0.5))
```
---
src/tirx/script/builder/ir.cc | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/tirx/script/builder/ir.cc b/src/tirx/script/builder/ir.cc
index 1f198b4238..0e67fd1514 100644
--- a/src/tirx/script/builder/ir.cc
+++ b/src/tirx/script/builder/ir.cc
@@ -784,18 +784,27 @@ void BufferStore(Buffer buffer, PrimExpr value,
ffi::Array<PrimExpr> indices,
<< ": LHS is `" << lhs_dtype << "`, RHS is
`" << rhs_dtype
<< "`, indexing lanes: " << index_lanes;
}
+ value = tvm::cast(lhs_dtype, value);
+ }
+ tvm::tirx::BufferStore store(buffer, value, indices, predicate);
+ if (lhs_dtype != rhs_dtype) {
if (lhs_dtype.code() != rhs_dtype.code()) {
if ((lhs_dtype.MatchesCode(DLDataTypeCode::kDLInt,
DLDataTypeCode::kDLUInt)) &&
(rhs_dtype.code() == DLDataTypeCode::kDLFloat ||
rhs_dtype.code() == DLDataTypeCode::kDLBfloat)) {
+ ffi::String kernel_name = "<unknown>";
+ if (ffi::Optional<PrimFuncFrame> frame =
IRBuilder::Current()->FindFrame<PrimFuncFrame>()) {
+ kernel_name = frame.value()->name.value_or("<anonymous>");
+ }
LOG(WARNING) << "Casting in BufferStore may lose precision"
<< ": LHS is `" << lhs_dtype << "`, RHS is `" << rhs_dtype
- << "`, indexing lanes: " << index_lanes;
+ << "`, indexing lanes: " << index_lanes << ", kernel: `"
<< kernel_name << "`"
+ << "\nBufferStore:\n"
+ << store;
}
}
- value = tvm::cast(lhs_dtype, value);
}
- AddToParent(tvm::tirx::BufferStore(buffer, value, indices, predicate));
+ AddToParent(store);
}
DeclBufferFrame DeclBuffer(ffi::Array<PrimExpr> shape, PrimType dtype,
ffi::String buffer_name,
