areusch commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r414918682
##########
File path: src/runtime/micro/openocd_low_level_device.cc
##########
@@ -210,9 +210,9 @@ class OpenOCDLowLevelDevice final : public LowLevelDevice {
// NOTE: OpenOCD will call any request larger than this constant an "absurd
// request".
/*! \brief maximum number of bytes allowed in a single memory transfer */
- static const constexpr ssize_t kMemTransferLimit = 64000;
+ static const constexpr ssize_t kMemTransferLimit = 8000;
Review comment:
I can't remember anymore exactly where this limit hits, but iirc it's
due to mac os x pipe buffering. I think it's because we are reading the pipe
line by line on the TVM side, but if you issue a memory transfer that prints
more than ~24k of characters, the os pipe buffer fills up before the newline
char is sent and we deadlock. updated comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
