weberlo commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r418643505
##########
File path: src/runtime/micro/openocd_low_level_device.cc
##########
@@ -210,9 +210,9 @@ class OpenOCDLowLevelDevice final : public LowLevelDevice {
// NOTE: OpenOCD will call any request larger than this constant an "absurd
// request".
/*! \brief maximum number of bytes allowed in a single memory transfer */
- static const constexpr ssize_t kMemTransferLimit = 64000;
+ static const constexpr ssize_t kMemTransferLimit = 8000;
Review comment:
okay. we might want some preprocessor magic to detect if the platform is
linux or mac and set this constant accordingly, because leaving it at 8k means
linux is issuing 8 times more requests than needs to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
