masahi edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635644901
I expect constants to be available to external codegen at compile time. Otherwise we cannot do constant folding. @comaniac Under the current implementation of merge composite + pattern partitioning, do you hit this visitor https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/contrib/dnnl/codegen.cc#L156 during DNNL codegen? Sorry I didn't put thought on this issue when merging #5663 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
