kevinthesun commented on a change in pull request #4312:
URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r434927495
##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -210,14 +210,22 @@ struct SplitAttrs : public tvm::AttrsNode<SplitAttrs> {
/*! \brief Attributes for StridedSlice operator */
struct StridedSliceAttrs : public tvm::AttrsNode<StridedSliceAttrs> {
- Array<Integer> begin;
- Array<Integer> end;
- Array<Integer> strides;
+ Optional<Array<Integer>> begin;
+ Optional<Array<Integer>> end;
+ Optional<Array<Integer>> strides;
+ bool slice_mode;
TVM_DECLARE_ATTRS(StridedSliceAttrs, "relay.attrs.StridedSliceAttrs") {
TVM_ATTR_FIELD(begin).describe("Indices for begin of slice, begin index is
also inclusive");
TVM_ATTR_FIELD(end).describe("Indices for end of slice, end index is
exclusive");
- TVM_ATTR_FIELD(strides).set_default(Array<Integer>({})).describe("Stride
values of the slice");
+ TVM_ATTR_FIELD(strides).describe("Stride values of the slice");
+ TVM_ATTR_FIELD(slice_mode)
Review comment:
Will ```use_size``` be more clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
