t-vi commented on a change in pull request #5727:
URL: https://github.com/apache/incubator-tvm/pull/5727#discussion_r435423642
##########
File path: src/target/llvm/intrin_rule_rocm.cc
##########
@@ -40,8 +41,59 @@ inline void DispatchExternOCML(const TVMArgs& args,
TVMRetValue* rv) {
*rv = CallNode::make(call->dtype, intrinsic_name.str(), call->args,
CallNode::PureExtern);
}
+inline void DispatchShuffle(const TVMArgs& targs, TVMRetValue* rv) {
+ PrimExpr e = targs[0];
Review comment:
While I do agree in general, the e here is more or less a cast and I
took this straight from `intrin_rule_llvm.h`, including the naming.
Oh well, I'll call it e_call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
